following contributing.md results in being unable to run make

[kylrth]

System Info

OS: Ubuntu 20.04 LTS
branch: master
Python: 3.9

Who can help?

@hwchase17

Information

• The official example notebooks/scripts
• My own modified scripts

Related Components

• LLMs/Chat Models
• Embedding Models
• Prompts / Prompt Templates / Prompt Selectors
• Output Parsers
• Document Loaders
• Vector Stores / Retrievers
• Memory
• Agents / Agent Executors
• Tools / Toolkits
• Chains
• Callbacks/Tracing
• Async

Reproduction

I followed the steps as described in .github/contributing.md:

1. fork the repo
2. clone the fork
3. conda create -n langchain python=3.9
4. conda activate langchain
5. pip install -U pip setuptools
6. pip install poetry
7. poetry completions bash >> ~/.bash_completion
8. poetry config virtualenvs.prefer-active-python true
9. poetry install -E all <-- this command failed to unlock the gnome keyring, so I reran according to poetry#1917 below:
10. PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring poetry install -E all
11. make format

Running make format results in the following:

Traceback (most recent call last):
  File "/home/kyle/.miniconda3/envs/langchain/bin/make", line 5, in <module>
    from scripts.proto import main
ModuleNotFoundError: No module named 'scripts'

which make returns a make script installed in my conda env bin, with the following contents:

#!/home/kyle/.miniconda3/envs/langchain/bin/python
# -*- coding: utf-8 -*-
import re
import sys
from scripts.proto import main
if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
    sys.exit(main())

I'm not sure what this is. I'm pretty sure I followed the directions correctly.

Expected behavior

I should be able to run make format without a problem at this point.

[abhinavbh08]

Same here

[aj-hoang]

I can reproduce the issue too, instead I've used make from /usr/bin/make rather than the one in the python virtual environment: #6915 (comment) and that works for me in the meantime, not sure if that's the intended behaviour in this project, but hopefully someone can shine a light on this :)

[xznhj8129]

I installed langchain's requirements on my system instead of a virtual environment. I shouldn't have done that. Everything is broken now...

[kylrth]

@hwchase17 sorry to ping but this is probably going to keep a lot of people from contributing. Any idea what's wrong?

[jedi4ever]

It seems that the module tigrisdb installs make and this is the one confusing it.

pip list | tail -n +3 | cut -d" " -f1 | xargs pip show -f and then grep for bin/make

Name: tigrisdb
Version: 1.0.0b6
Summary: Python SDK for Tigris <http://www.tigrisdata.com>
Home-page: https://www.github.com/tigrisdata/tigris-client-python
Author: Tigris team
Author-email: support@tigrisdata.com
License: Apache-2.0
Location: /opt/homebrew/anaconda3/envs/langchain-repo/lib/python3.9/site-packages
Requires: grpcio-tools, protobuf
Required-by: 
Files:
  ../../../bin/make
  api/generated/google/api/__pycache__/annotations_pb2.cpython-39.pyc
  api/generated/google/api/__pycache__/annotations_pb2_grpc.cpython-39.pyc
  api/generated/google/api/__pycache__/field_behavior_pb2.cpython-39.pyc
  api/generated/google/api/__pycache__/field_behavior_pb2_grpc.cpython-39.pyc

doing a simple pip uninstall tigrisdb makes make work again :)
Not the permanent solution, but maybe a workaround for now.
And one step closer to the fix ?

[jedi4ever]

In the docs is says to do export PATH="/Users/some.user/.local/bin:$PATH"
this would mean it will find the make binary of poe env first , we could change it to appending it at the end (which is the usual I guess ?)

export PATH="$PATH:/Users/some.user/.local/bin" ?

Alternative fix right now is to delete the make file from the tigrisdb package

[jedi4ever]

likely introduced by #5703 cc @adilansari to the rescue

[adilansari]

@jedi4ever @kylrth would removing tigrisdb from dependencies solve the issue?

https://github.com/hwchase17/langchain/blob/931e68692e75ae22ab245c4d8d24b62c1f95cc59/pyproject.toml#L317

[kylrth]

I haven't tested it but it sounds like it will, but if that dependency is important for development then it needs to be present, correct? Whatever we do, we need to make the instructions in contributing.md work out of the box.

[balnarendrasapa]

I tried uninstalling tigrisdb. It is removing the make. and when i try running make 'no such file or directory' is showing up.

[dosubot]

Hi, @kylrth! I'm Dosu, and I'm here to help the LangChain team manage their backlog. I wanted to let you know that we are marking this issue as stale.

Based on my understanding, you are experiencing an issue where running make format results in a ModuleNotFoundError. Other users have also reported the same issue and have suggested workarounds such as using /usr/bin/make instead of the one in the Python virtual environment or uninstalling the tigrisdb module. However, it seems that the issue is still ongoing and you are seeking help from @hwchase17 to resolve it.

Before we proceed, we would like to confirm if this issue is still relevant to the latest version of the LangChain repository. If it is, please let us know by commenting on this issue. Otherwise, feel free to close the issue yourself or it will be automatically closed in 7 days.

Thank you for your understanding and cooperation. We look forward to hearing from you soon.