Skip to content

chore(langchain): add ruff rules D (except D100 and D104)#31994

Merged
Mason Daugherty (mdrxy) merged 3 commits intolangchain-ai:masterfrom
cbornet:langchain-ruff-d-fixes
Sep 8, 2025
Merged

chore(langchain): add ruff rules D (except D100 and D104)#31994
Mason Daugherty (mdrxy) merged 3 commits intolangchain-ai:masterfrom
cbornet:langchain-ruff-d-fixes

Conversation

@cbornet
Copy link
Copy Markdown
Collaborator

@cbornet Christophe Bornet (cbornet) commented Jul 12, 2025

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Sep 8, 2025 9:47pm

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jul 12, 2025

CodSpeed WallTime Performance Report

Merging #31994 will not alter performance

Comparing cbornet:langchain-ruff-d-fixes (52101f0) with master (017348b)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jul 12, 2025

CodSpeed Instrumentation Performance Report

Merging #31994 will not alter performance

Comparing cbornet:langchain-ruff-d-fixes (52101f0) with master (017348b)

Summary

✅ 14 untouched benchmarks

@cbornet Christophe Bornet (cbornet) force-pushed the langchain-ruff-d-fixes branch 2 times, most recently from 1a731d6 to ff6b28d Compare July 12, 2025 17:59
@cbornet Christophe Bornet (cbornet) changed the title langchain: Add ruff rules D except D1 feat(langchain): Add ruff rules D except D1 Jul 13, 2025
@cbornet Christophe Bornet (cbornet) changed the title feat(langchain): Add ruff rules D except D1 feat(langchain): add ruff rules D except D1 Jul 13, 2025
@cbornet Christophe Bornet (cbornet) force-pushed the langchain-ruff-d-fixes branch 3 times, most recently from 0542395 to 6bfc242 Compare July 25, 2025 22:52
@cbornet Christophe Bornet (cbornet) changed the title feat(langchain): add ruff rules D except D1 chore(langchain): add ruff rules D (except D100 and D104) Jul 25, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds additional ruff linting rules from the pydocstyle (D) category except for D100 and D104. The changes focus on enforcing proper docstring formatting standards across the langchain codebase.

Key changes include:

  • Standardizing docstring formats to end with periods
  • Updating multi-line docstrings to follow proper formatting guidelines
  • Removing unnecessary empty lines after docstring opening quotes
  • Converting single-line docstrings that spanned multiple lines to proper single-line format

Reviewed Changes

Copilot reviewed 142 out of 143 changed files in this pull request and generated 3 comments.

File Description
pyproject.toml Expanded ruff rules from D1 to full D suite, added scripts exclusion
test files (multiple) Fixed docstring period endings and multi-line formatting
source files (multiple) Standardized docstring formatting, removed unnecessary empty lines
integration test files Enhanced docstring documentation with proper Args/Returns sections

@cbornet Christophe Bornet (cbornet) force-pushed the langchain-ruff-d-fixes branch 2 times, most recently from 1a788ab to a91948f Compare August 13, 2025 13:00
@mdrxy Mason Daugherty (mdrxy) enabled auto-merge (squash) September 8, 2025 21:46
@mdrxy Mason Daugherty (mdrxy) merged commit c3b28c7 into langchain-ai:master Sep 8, 2025
39 checks passed
@cbornet Christophe Bornet (cbornet) deleted the langchain-ruff-d-fixes branch September 9, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants