Skip to content

chore(langchain): add ruff rules ARG#32110

Merged
Mason Daugherty (mdrxy) merged 2 commits intolangchain-ai:masterfrom
cbornet:langchain-ruff-arg
Jul 26, 2025
Merged

chore(langchain): add ruff rules ARG#32110
Mason Daugherty (mdrxy) merged 2 commits intolangchain-ai:masterfrom
cbornet:langchain-ruff-arg

Conversation

@cbornet
Copy link
Copy Markdown
Collaborator

@cbornet Christophe Bornet (cbornet) commented Jul 19, 2025

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2025 10:28pm

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jul 19, 2025 •
edited
Loading

CodSpeed WallTime Performance Report

Merging #32110 will not alter performance

Comparing cbornet:langchain-ruff-arg (73c0448) with master (a2ad5ac)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jul 19, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #32110 will not alter performance

Comparing cbornet:langchain-ruff-arg (73c0448) with master (a2ad5ac)

Summary

✅ 14 untouched benchmarks

mdrxy
Mason Daugherty (mdrxy) reviewed Jul 21, 2025
View reviewed changes
libs/langchain/langchain/smith/evaluation/progress.py
total: int,
ncols: int = 50,
end_with: str = "\n",
**kwargs: Any,
Copy link
Copy Markdown
Member

@mdrxy Mason Daugherty (mdrxy) Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Collaborator Author

@cbornet Christophe Bornet (cbornet) Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProgressBarCallback doesn't use kwargs.
It seems it was there by mistake and nobody would call it with args other than the named args of the signature.
In theory it would be a breaking change, but in practice I think it's OK.
LMK if you prefer to keep the kwargs.

Copy link
Copy Markdown
Member

@mdrxy Mason Daugherty (mdrxy) Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to Eugene Yurtsev (@eyurtsev) for decision

@eyurtsev Eugene Yurtsev (eyurtsev) changed the title feat(langchain): add ruff rules ARG chore(langchain): add ruff rules ARG Jul 25, 2025
@mdrxy Mason Daugherty (mdrxy) merged commit efdfa00 into langchain-ai:master Jul 26, 2025
41 checks passed
@cbornet Christophe Bornet (cbornet) deleted the langchain-ruff-arg branch July 27, 2025 05:50
Navpreet Singh (20ns) pushed a commit to 20ns/langchain that referenced this pull request Aug 2, 2025
@cbornet @mdrxy @20ns
chore(langchain): add ruff rules ARG (langchain-ai#32110)
21d14b8 
See https://docs.astral.sh/ruff/rules/#flake8-unused-arguments-arg

Co-authored-by: Mason Daugherty <mason@langchain.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdrxy Mason Daugherty (mdrxy) mdrxy approved these changes

@eyurtsev Eugene Yurtsev (eyurtsev) Awaiting requested review from eyurtsev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbornet @mdrxy