chore(langchain): add ruff rules SLF#32112
chore(langchain): add ruff rules SLF#32112Eugene Yurtsev (eyurtsev) merged 2 commits intolangchain-ai:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| ) | ||
| try: | ||
| while self.agent_executor._should_continue( | ||
| while self.agent_executor._should_continue( # noqa: SLF001 |
There was a problem hiding this comment.
It's OK for AgentExecutorIterator to access private members of AgentExecutor
CodSpeed WallTime Performance ReportMerging #32112 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32112 will not alter performanceComparing Summary
|
|
Nit - probably not really a feature, right? More like a chore? |
| return cls(llm=llm, prompt=prompt_template) | ||
|
|
||
| def _get_num_tokens(self, text: str) -> int: | ||
| def get_num_tokens(self, text: str) -> int: |
There was a problem hiding this comment.
This shouldn't be made public. We don't want more users accessing this
There was a problem hiding this comment.
OK. Is it because all the using classes are deprecated ?
I see that BaseQAWithSourcesChain is deprecated but not some of its subclasses (VectorDBQAWithSourcesChain and RetrievalQAWithSourcesChain). Shouldn't they be deprecated as well ?
There was a problem hiding this comment.
done
Eugene Yurtsev (eyurtsev)
changed the title
Eugene Yurtsev (eyurtsev)
merged commit e1238b8
into
langchain-ai:master
4 participants
See https://docs.astral.sh/ruff/rules/private-member-access/