Skip to content

chore(langchain): add ruff rules D1 (except D100 and D104)#32123

Merged
Eugene Yurtsev (eyurtsev) merged 1 commit intolangchain-ai:masterfrom
cbornet:langchain-ruff-d1
Jul 25, 2025
Merged

chore(langchain): add ruff rules D1 (except D100 and D104)#32123
Eugene Yurtsev (eyurtsev) merged 1 commit intolangchain-ai:masterfrom
cbornet:langchain-ruff-d1

Conversation

@cbornet
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2025 9:05am

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jul 20, 2025

CodSpeed WallTime Performance Report

Merging #32123 will not alter performance

Comparing cbornet:langchain-ruff-d1 (832931f) with master (3496e17)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jul 20, 2025

CodSpeed Instrumentation Performance Report

Merging #32123 will not alter performance

Comparing cbornet:langchain-ruff-d1 (832931f) with master (3496e17)

Summary

✅ 14 untouched benchmarks

llm: Optional[BaseLanguageModel] = None
evaluator_type: EvaluatorType = EvaluatorType.CRITERIA

def __init__(
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constructor doesn't seem useful.

@eyurtsev Eugene Yurtsev (eyurtsev) changed the title feat(langchain): add ruff rules D1 (except D100 and D104) chore(langchain): add ruff rules D1 (except D100 and D104) Jul 25, 2025
@eyurtsev Eugene Yurtsev (eyurtsev) merged commit 12ae42c into langchain-ai:master Jul 25, 2025
30 checks passed
@cbornet Christophe Bornet (cbornet) deleted the langchain-ruff-d1 branch July 25, 2025 16:05
@brennercruvinel
Copy link
Copy Markdown

god, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants