chore(langchain): strip_ansi fucntion to remove ANSI escape sequences#32200
Merged
Eugene Yurtsev (eyurtsev) merged 2 commits intolangchain-ai:masterfrom Jul 25, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
CodSpeed WallTime Performance ReportMerging #32200 will improve performances by 16.29%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | test_import_time[CallbackManager] |
482.2 ms | 414.7 ms | +16.29% |
| ⚡ | test_import_time[LangChainTracer] |
461.5 ms | 411.7 ms | +12.08% |
| ⚡ | test_import_time[RunnableLambda] |
261.6 ms | 232.6 ms | +12.44% |
| ⚡ | test_import_time[Runnable] |
255.5 ms | 230.2 ms | +10.99% |
CodSpeed Instrumentation Performance ReportMerging #32200 will not alter performanceComparing Summary
|
strip_ansi fucntion to remove ANSI escape sequences
7 tasks
Eugene Yurtsev (eyurtsev)
requested changes
Jul 25, 2025
strip_ansi fucntion to remove ANSI escape sequencesstrip_ansi fucntion to remove ANSI escape sequences
Eugene Yurtsev (eyurtsev)
approved these changes
Jul 25, 2025
8f5ec20
into
langchain-ai:master
42 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug in the file callback test where ANSI escape codes were causing test failures. The improved test now properly handles ANSI escape sequences by:
strip_ansifunction consistently to all file contentsThe changes ensure tests pass reliably even when terminal control sequences are present in the output
Issue: Fixes #32150
Dependencies: None required - uses existing dependencies only.