fix(langchain-classic): pass default to config.getoption#34034
Merged
Mason Daugherty (mdrxy) merged 5 commits intolangchain-ai:masterfrom Dec 27, 2025
Merged
Conversation
github-actions
bot
added
langchain-classic
Eugene Yurtsev (eyurtsev)
changed the title
config.getoptionconfig.getoption
github-actions
bot
added
fix
Member
|
Should we also extend this to |
github-actions
bot
added
fix
Member
|
Sarah Clark (@sarahec) quickly following up |
Mason Daugherty (mdrxy)
added
the
waiting-on-author
Contributor
Author
I'm sorry, I missed seeing that. Yes, I can make the edit. UPDATE: Done. |
Mason Daugherty (mdrxy)
approved these changes
Dec 27, 2025
Mason Daugherty (mdrxy)
merged commit 10de0a5
into
langchain-ai:master
47 checks passed
Mason Daugherty (mdrxy)
removed
the
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34033