Skip to content

revert: Revert "fix(core): trace invocation params in metadata"#36322

Merged
ccurme (ccurme) merged 1 commit intomasterfrom
revert-36080-cc/invocation_params
Mar 27, 2026
Merged

revert: Revert "fix(core): trace invocation params in metadata"#36322
ccurme (ccurme) merged 1 commit intomasterfrom
revert-36080-cc/invocation_params

Conversation

@jacoblee93
Copy link
Copy Markdown
Contributor

Reverts #36080

This logic should go in LangSmith SDK instead

@github-actions github-actions bot added core `langchain-core` package issues & PRs internal revert PRs made to revert a change size: S 50-199 LOC labels Mar 27, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2026

Merging this PR will degrade performance by 26.16%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 1 regressed benchmark
✅ 12 untouched benchmarks
⏩ 27 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_async_callbacks_in_sync 14.9 ms 20.2 ms -26.16%

Comparing revert-36080-cc/invocation_params (bfd1072) with master (494b760)2

Open in CodSpeed

Footnotes

  1. 27 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (475408f) during the generation of this report, so 494b760 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ccurme ccurme (ccurme) merged commit 389f7ad into master Mar 27, 2026
91 of 92 checks passed
@ccurme ccurme (ccurme) deleted the revert-36080-cc/invocation_params branch March 27, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core `langchain-core` package issues & PRs internal revert PRs made to revert a change size: S 50-199 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants