Type-safety of Channel.subscribeTo#109
Merged
Nuno Campos (nfcampos) merged 1 commit intolangchain-ai:mainfrom Apr 16, 2024
Merged
Type-safety of Channel.subscribeTo#109Nuno Campos (nfcampos) merged 1 commit intolangchain-ai:mainfrom
Nuno Campos (nfcampos) merged 1 commit intolangchain-ai:mainfrom
Conversation
… runtime is a type-error
Member
Brace Sproul (bracesproul)
left a comment
Brace Sproul (bracesproul)
left a comment
There was a problem hiding this comment.
This looks reasonable to me. cc Nuno Campos (@nfcampos) for a second look
Nuno Campos (nfcampos)
approved these changes
Apr 16, 2024
Contributor
Nuno Campos (nfcampos)
left a comment
Nuno Campos (nfcampos)
left a comment
There was a problem hiding this comment.
Thanks for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure
Channel.subscribeTo(["input"], { key: "key" })which throws at runtime is a type-error.