Skip to content

Conversation

@jhoughtelin
Copy link
Contributor

This implements tests for weekday methods that were lacking tests. This includes tests for Event->tuesdays(), Event->wednesdays(), Event->weekdays() and Event->weeklyOn()

This PR just adds a little bit more test coverage specifically for the weekday methods.

Before:

PHPUnit 5.5.4 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.0.9 with Xdebug 2.4.1
Configuration: /Volumes/CODE/projects/crunz_jh/phpunit.xml

............                                                      12 / 12 (100%)

Time: 181 ms, Memory: 12.00MB

OK (12 tests, 46 assertions)

2016-08-26_1648

After:

PHPUnit 5.5.4 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.0.9 with Xdebug 2.4.1
Configuration: /Volumes/CODE/projects/crunz_jh/phpunit.xml

............                                                      12 / 12 (100%)

Time: 164 ms, Memory: 12.00MB

OK (12 tests, 50 assertions)

2016-08-26_1649

…is includes tests for Event->tuesdays(), Event->wednesdays(), Event->weekdays() and Event->weeklyOn()
public function setUp()
{
$this->id = uniqid();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-formatting fail. =(

@PabloKowalczyk PabloKowalczyk merged commit 8a1e649 into lavary:master Apr 8, 2018
@PabloKowalczyk
Copy link
Collaborator

Thanks @jhoughtelin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants