Skip to content

Conversation

@bashgeek
Copy link

@bashgeek bashgeek commented Dec 6, 2021

Fixes #389

Added Symfony 6 versions to composer.json and fixed some type hints that are now required. All tests run fine after.

@PabloKowalczyk
Copy link
Collaborator

Could you add Symfony 6 checks to strategy matrix in .github/workflows/code_checks.yaml and change target branch to 3.2 (https://github.com/lavary/crunz/tree/3.2)?

@PabloKowalczyk PabloKowalczyk added this to the v3.2 milestone Dec 7, 2021
@bashgeek bashgeek changed the base branch from master to 3.2 December 8, 2021 01:12
@bashgeek
Copy link
Author

bashgeek commented Dec 8, 2021

Could you add Symfony 6 checks to strategy matrix in .github/workflows/code_checks.yaml and change target branch to 3.2 (https://github.com/lavary/crunz/tree/3.2)?

Done!

@PabloKowalczyk
Copy link
Collaborator

For some reason Windows build failed and could rebase your branch on 3.2?

@bashgeek
Copy link
Author

bashgeek commented Dec 8, 2021

For some reason Windows build failed and could rebase your branch on 3.2?

Seems to be an (newly introduced?) issue with the shivammathur/setup-php@v2 runtime:
https://github.com/lavary/crunz/runs/4453789755?check_suite_focus=true#step:3:12

Had nothing to do with the changes made by me (didn't touch that part), it ran through fine in my workflow for the last commit (which is identical):
https://github.com/bashgeek/crunz/runs/4451594357?check_suite_focus=true

Maybe just try to rerun those workflows?

@PabloKowalczyk PabloKowalczyk mentioned this pull request Dec 12, 2021
@PabloKowalczyk
Copy link
Collaborator

Sorry for that, but you started your branch on master and you have commit ab7c590 which shouldn't be there, also i plan to remove master branch. This is why there are changelog and readme changes. Could you remove mentioned commit?

You are right, looks like Windows CI fails are not related to your changes.

@bashgeek
Copy link
Author

@PabloKowalczyk done!

@PabloKowalczyk PabloKowalczyk merged commit 02e622a into lavary:3.2 Dec 17, 2021
@PabloKowalczyk
Copy link
Collaborator

Thank you @bashgeek

@bashgeek bashgeek deleted the symfony6 branch December 17, 2021 08:16
@PabloKowalczyk PabloKowalczyk mentioned this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Symfony 6

2 participants