Sort replies from oldest to newest #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekkyojin
force-pushed
the
sort-commentreplies
branch
from
26f56bb to
6819ae4
Compare
Member
|
Review coming soon! Thank you |
akinwale
approved these changes
Dec 5, 2020
Contributor
akinwale
left a comment
akinwale
left a comment
There was a problem hiding this comment.
This looks good. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #948
What is the current behavior?
Replies to comments are ordered in a way which newest ones appear first, making difficult to follow the conversation if there are lots of replies, as it requires to scroll down to the latest one and then scrolling up while reading adn then scrolling down again to read next comment.
What is the new behavior?
Replies are ordered on its chronological order: older are shown first and followed by newer ones.
New behavior is also consistent with LBRY.TV and ODYSEE.COM. See for example https://lbry.tv/microsoft:2. Replies from the comments are the bottom are now shown in the same order in both the site and LBRY Android app.