Add id to stylesheet element #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemonsaurus
requested changes
Feb 7, 2022
| @@ -30,7 +30,7 @@ def bulma(theme: str = "") -> SafeString: | |||
| css = static(f"css/{theme + '_' if theme else ''}bulma.css") | |||
| html = [ | |||
| f'<link rel="preload" href="{css}" as="style">', | |||
| f'<link rel="stylesheet" href="{css}">', | |||
| f'<link rel="stylesheet" href="{css}" id="bulma-css{"" if theme == "" else f"-{theme}"}">', | |||
There was a problem hiding this comment.
maybe you can refactor this so it doesn't give people a heart attack? 🌞
Maybe this id can be created on an earlier line so that we don't have to have an f string within an f string with a ternary conditional, that's a lot of logic to stuff into one line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
idattribute to the CSS stylesheet so it can be easily queried.The default theme is set to
"bulma-css"if there is a theme it is set to
"bulma-css-{theme}"