[LoRa/TTN] Add raw packed decoder (more values, less data) & reduce joins #2546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume module is joined. If not, a TX attempt will return "not_joined" after which a join should be attempted.
For LoRa, it may take a while to send out samples of different plugins. This makes it hard to match samples belonging to the same set after receiving them. The Sample Set Initiator is a task index which should always be considered as the first of a set samples sent to the controller. For example when triggering to send a set of samples from rules, its order can be always the same. Setting the initiator to the first one of the sequence, the same sample set counter will be sent along with the samples.
This does allow uploading even more parameters than the 4 supported by ESPeasy, since encoder and decoder can be tailored to the specific plugin. For example the GPS plugin can now upload 7 parameters in only 20 bytes. Still to do: Why can the decoder not handle encoding per 24 bit? (lat/lon do fit perfectly fine in 24 bit).
This does send out all 11 values of the sysinfo plugin.
Makes the rest of the decoder.js a lot simpler. Also changed the GPS lat/long into 3 bytes again, saving 2 bytes in the packet length. GPS outputs now 7 values using 18 bytes (incl. header)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented support for encoding/decoding raw packed data for plugins.
Also improved LoRa/TTN library to perform a join less often.
As long as the module remains powered, a join should not be needed anymore.This prevents a lot of unneeded downward traffic.