Switch to ruby-lsp VSCode plugin #489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve lewagon/teachers#1780 It seemed to work for me locally. The only thing I wasn't sure of is if we needed to do anything to make it play nice with `rubocop` but maybe no...?
Eschults
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Thank you @ajdubovoy for testing it locally.
The only thing I wasn't sure of is if we needed to do anything to make it play nice with rubocop but maybe no...?
We should, otherwise students will be confused by linter warnings not allowing them to have a good style w/ rake and on Kitt. What are the rules enforced by default if the linter ignores the .rubocop.yml?
|
I'm actually just not sure. I'm not a VSCode user and mine has never been able to run |
|
But currently we're not installing anything separately for rubocop and I think the default behavior of ruby-lsp is to respect the config actually...I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve https://github.com/lewagon/teachers/issues/1780
It seemed to work for me locally. The only thing I wasn't sure of is if
we needed to do anything to make it play nice with
rubocopbut maybeno...?