Fix CMake configure on Windows #689
Merged
+21
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
approved these changes
May 5, 2025
Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
approved these changes
May 5, 2025
There was a problem hiding this comment.
I took the liberty to add a commit that runs the CMake builds on Appveyor.
https://ci.appveyor.com/project/libtom/libtomcrypt/builds/52001098 also shows that the CMake build on Windows was broken before your patch, so thanks a lot for that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
target_link_librariesbefore a target has been added seems to cause errors during CMake configuration.Since BCrypt was fixed in b508028, this error seems to occur.
Moving the
target_link_librariescall after the library has been added fixes this.