Don't generate a commitment if we cannot afford a holding cell feerate #3828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @wpaulino as a reviewer! |
tankyleo
force-pushed
the
lonely-commitment
branch
from
184efad to
413e895
Compare
tankyleo
force-pushed
the
lonely-commitment
branch
3 times, most recently
from
d0a4441 to
b2a166c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3828 +/- ##
==========================================
+ Coverage 89.90% 90.36% +0.46%
==========================================
Files 160 160
Lines 129272 133275 +4003
Branches 129272 133275 +4003
==========================================
+ Hits 116218 120432 +4214
+ Misses 10360 10142 -218
- Partials 2694 2701 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tankyleo
force-pushed
the
lonely-commitment
branch
2 times, most recently
from
e4f2142 to
cc03f48
Compare
While an `update_fee` is in the holding cell, it is possible for HTLCs to get added to the commitment transaction such that when we release the holding cell, we can no longer afford this new feerate. In that case, we previously would drop the fee update, but still send a commitment (at the old feerate), which is a break of the specification. We now stop generating this lonely commitment when the fee update gets dropped upon release from the holding cell.
tankyleo
force-pushed
the
lonely-commitment
branch
from
cc03f48 to
d94822c
Compare
|
🔔 1st Reminder Hey @wpaulino! This PR has been waiting for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While an
update_feeis in the holding cell, it is possible for HTLCs to get added to the commitment transaction such that when we release the holding cell, we can no longer afford this new feerate.In that case, we previously would drop the fee update, but still send a commitment (at the old feerate), which is a break of the specification.
We now stop generating this lonely commitment when the fee update gets dropped upon release from the holding cell.