Skip to content

Fix possible dust HTLC sweep tx when feerate remains unchanged during a bump #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix possible dust HTLC sweep tx when feerate remains unchanged during a bump #3832

wants to merge 1 commit into from

Conversation

whfuyn
Copy link

@whfuyn whfuyn commented Jun 6, 2025

Fix #3831

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jun 6, 2025 •
edited
Loading

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (97f0e4b) to head (ab132ab).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3832      +/-   ##
==========================================
- Coverage   89.91%   89.90%   -0.01%     
==========================================
  Files         160      160              
  Lines      129307   129581     +274     
  Branches   129307   129581     +274     
==========================================
+ Hits       116270   116505     +235     
- Misses      10349    10383      +34     
- Partials     2688     2693       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldk-reviews-bot ldk-reviews-bot requested a review from wpaulino June 6, 2025 10:50
wpaulino
wpaulino reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind updating the commit message to follow these guidelines?

@wpaulino wpaulino requested a review from TheBlueMatt June 6, 2025 18:18
@whfuyn
Ensure package output is not less than dust limit
ab132ab 
When bumping an HTLC sweep transaction, if the feerate remains
unchanged, `feerate_bump` doesn't check whether the output amount
is below the dust limit. However, this situation can occur if
the transaction's inputs are modified.

See also: lightningdevkit#3831
@whfuyn whfuyn force-pushed the fix-dust-htlc-sweep-tx branch from 1a19a4a to ab132ab Compare June 7, 2025 08:42
@whfuyn
Copy link
Author

whfuyn commented Jun 7, 2025

Hi, @wpaulino.
Thanks for the feedback. I've revised the commit message according to the guideline. Let me know if any further revisions are needed.

@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

1 similar comment
@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @TheBlueMatt! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpaulino wpaulino wpaulino left review comments

@TheBlueMatt TheBlueMatt Awaiting requested review from TheBlueMatt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTLC sweep transaction fails to broadcast due to dust output
3 participants
@whfuyn @ldk-reviews-bot @wpaulino