Skip to content

speed up kto loss and some refactor #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2024
Merged

speed up kto loss and some refactor #495

merged 1 commit into from
Dec 21, 2024

Conversation

shivam15s
Copy link
Collaborator

@shivam15s shivam15s commented Dec 21, 2024 •
edited
Loading

Summary

KTO LOSS

Memory

image

Speed

image

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

hebiao064
hebiao064 reviewed Dec 21, 2024
View reviewed changes
@hebiao064 hebiao064 merged commit 85a582e into kto_loss Dec 21, 2024
@hebiao064 hebiao064 deleted the shisahni/kto_loss_mod branch December 21, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebiao064 hebiao064 hebiao064 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivam15s @hebiao064