Skip to content

Solar pro implementation #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

KareemMusleh
Copy link
Contributor

@KareemMusleh KareemMusleh commented May 4, 2025

Summary

implements #537

Details

I don't know if modeling_solar.py and configuration_solar.py are in the right place.

I also changed labels is not None to self.training and (labels is not None) in solar.py. To make it similar to how llama.py is written.

Testing Done

  • Hardware Type: NVIDIA GeForce MX230
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence
  • write new tests

@KareemMusleh KareemMusleh marked this pull request as draft May 4, 2025 18:48
@KareemMusleh KareemMusleh marked this pull request as ready for review May 5, 2025 09:43
@KareemMusleh
Copy link
Contributor Author

what other tests should I add?

@vaibhavjindal
Copy link
Collaborator

what other tests should I add?

Please add fp16 and fp32 convergence tests as well.
See #685 and #692

@KareemMusleh
Copy link
Contributor Author

@vaibhavjindal done! I don't have the hardware to test it but I think it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants