Skip to content

fix vocab_size path for gemma3 #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix vocab_size path for gemma3 #774

wants to merge 4 commits into from

Conversation

winglian
Copy link
Contributor

Summary

using self.vocab_size for the multimodal forward likely never worked or was deprecated in a transformers change.

@Tcc0403 Tcc0403 mentioned this pull request Jun 25, 2025
Closed
3 tasks
@ELanning
Copy link

Needs image_features = self.model.get_image_features(pixel_values) on line 232 too, otherwise worked for me.

shimizust
shimizust reviewed Jun 30, 2025
View reviewed changes
.idea/workspace.xml
Copy link
Collaborator

@shimizust shimizust Jun 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove and add .idea to the .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimizust shimizust shimizust left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winglian @ELanning @shimizust @lancerts