Skip to content

INJECT_FACTS_AS_VARS default to True is deprecated warnings with Ansible 2.20 #829

@rlenferink

Description

@rlenferink

What happened:

When using the latest release of this role (1.17.7) with Ansible 2.20, the following warnings are given:

TASK [linux-system-roles.network : Abort applying teaming configuration if the system version of the managed host is EL10 or later] *******************************************************************************
[WARNING]: Deprecation warnings can be disabled by setting `deprecation_warnings=False` in ansible.cfg.
[DEPRECATION WARNING]: INJECT_FACTS_AS_VARS default to `True` is deprecated, top-level facts will not be auto injected after the change. This feature will be removed from ansible-core version 2.24.
Origin: <snip>/ansible/roles.galaxy/linux-system-roles.network/tasks/main.yml:36:7

34       use bonding instead
35   when:
36     - ansible_distribution_major_version | int > 9
         ^ column 7

Use `ansible_facts["fact_name"]` (no `ansible_` prefix) instead.

[DEPRECATION WARNING]: INJECT_FACTS_AS_VARS default to `True` is deprecated, top-level facts will not be auto injected after the change. This feature will be removed from ansible-core version 2.24.
Origin: <snip>/ansible/roles.galaxy/linux-system-roles.network/tasks/main.yml:37:7

35   when:
36     - ansible_distribution_major_version | int > 9
37     - ansible_distribution in __network_rh_distros
         ^ column 7

Use `ansible_facts["fact_name"]` (no `ansible_` prefix) instead.

skipping: [proxy-vm1.loc]

TASK [linux-system-roles.network : Check if updates for network packages are available through the DNF package manager due to wireless or team interfaces] ********************************************************
[DEPRECATION WARNING]: INJECT_FACTS_AS_VARS default to `True` is deprecated, top-level facts will not be auto injected after the change. This feature will be removed from ansible-core version 2.24.
Origin: <snip>/ansible/roles.galaxy/linux-system-roles.network/tasks/main.yml:52:7

50   check_mode: true
51   when:
52     - ansible_distribution == 'Fedora' or
         ^ column 7

Use `ansible_facts["fact_name"]` (no `ansible_` prefix) instead.

skipping: [proxy-vm1.loc]

TASK [linux-system-roles.network : Check if updates for network packages are available through the YUM package manager due to wireless or team interfaces] ********************************************************
[DEPRECATION WARNING]: INJECT_FACTS_AS_VARS default to `True` is deprecated, top-level facts will not be auto injected after the change. This feature will be removed from ansible-core version 2.24.
Origin: <snip>/ansible/roles.galaxy/linux-system-roles.network/tasks/main.yml:67:7

65   check_mode: true
66   when:
67     - ansible_distribution_major_version | int < 8
         ^ column 7

Use `ansible_facts["fact_name"]` (no `ansible_` prefix) instead.

skipping: [proxy-vm1.loc]

TASK [linux-system-roles.network : Ask user's consent to restart NetworkManager due to wireless or team interfaces] ***********************************************************************************************
skipping: [proxy-vm1.loc]

TASK [linux-system-roles.network : Install packages] **************************************************************************************************************************************************************
[DEPRECATION WARNING]: INJECT_FACTS_AS_VARS default to `True` is deprecated, top-level facts will not be auto injected after the change. This feature will be removed from ansible-core version 2.24.
Origin: <snip>/ansible/roles.galaxy/linux-system-roles.network/defaults/main.yml:78:47

76 # - python-gobject-base on RHEL7 (no python2-gobject-base :-/)
77 # - python3-gobject-base on Fedora 28+
78 __network_packages_default_gobject_packages: ["python{{
                                                 ^ column 47

Use `ansible_facts["fact_name"]` (no `ansible_` prefix) instead.

skipping: [proxy-vm1.loc]

What you expected to happen:

I expected that no deprecation warnings were given when using this Ansible role.

How to reproduce it (as minimally and precisely as possible):

Use this role with Ansible 2.20.1

Anything else we need to know?:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions