[clang-tidy] Check request: portability-minmax-macro-defensive

[denzor200]

Needs a check that will find std::min and std::max invocations without surrounding parentheses over the name. The check will suggest to insert parentheses around the name.

BEFORE:

int result = std::min(a, b); 

AFTER:

int result = (std::min)(a, b); 

Without parentheses the code that uses std::min and std::max might lead to compilation error in MSVC:

#include <algorithm> // std::min
#include <windows.h> // min macro

int main() {
    int a = 5, b = 10;
    
    // Compilation error in MSVC: 
    // "error C2589: '(': illegal token on right side of '::'"
    int result = std::min(a, b); 
    
    return 0;
}

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Denis Mikhailov (denzor200)

Needs a check that will find `std::min` and `std::max` invocations without surrounding parentheses over the name. The check will suggest to insert parentheses around the name.

BEFORE:

int result = std::min(a, b); 

AFTER:

int result = (std::min)(a, b); 

Without parentheses the code that uses std::min and std::max might lead to compilation error in MSVC:

#include <algorithm> // std::min
#include <windows.h> // min macro

int main() {
    int a = 5, b = 10;
    
    // Compilation error in MSVC: 
    // "error C2589: '(': illegal token on right side of '::'"
    int result = std::min(a, b); 
    
    return 0;
}

[vbvictor]

I don't think that it's a job for clang-tidy.
I think it's an issue with <windows.h> header and it's symbol pollution.

[vbvictor]

Instead of min and max it can be any templated function that overlaps with some macro that comes from some header (windows.h or not).

And If there is a strong compiler error provided, then it is catchable without clang-tidy.

[vbvictor]

Also, this code fails for both gcc and clang https://godbolt.org/z/6rca8cqM8, so it must be ill-formed, thus not analyzed.