Skip to content

[CMake] Fold export_executable_symbols_* into function args. #101741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2024
Merged

[CMake] Fold export_executable_symbols_* into function args. #101741

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49c9db2
[𝘀𝗽𝗿] initial version
cachemeifyoucan Aug 2, 2024
abb53cd
Properly fix the compatibility by folding export symbols into an argu…
cachemeifyoucan Aug 5, 2024
507c733
Fix test failures
cachemeifyoucan Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/cmake/modules/AddLLVM.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,7 +1070,8 @@ macro(add_llvm_executable name)
endif(LLVM_EXPORTED_SYMBOL_FILE)

if (DEFINED LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES AND
NOT LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES)
NOT LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES AND
NOT ENABLE_EXPORTS)
if(LLVM_LINKER_SUPPORTS_NO_EXPORTED_SYMBOLS)
set_property(TARGET ${name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,-no_exported_symbols")
Expand Down
2 changes: 2 additions & 0 deletions llvm/tools/llvm-jitlink/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ set(LLVM_LINK_COMPONENTS
TargetParser
)

set(ENABLE_EXPORTS ON)

add_llvm_tool(llvm-jitlink
llvm-jitlink.cpp
llvm-jitlink-coff.cpp
Expand Down
Loading