Skip to content

[llvm][llvm-lit] Enabled lit internal shell for llvm test suite #106324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

connieyzhu
Copy link
Contributor

This patch sets lit's internal shell to be the default shell when running llvm tests. Tests that REQUIRES: shell are not currently supported by the internal shell, so those tests are skipped with this implementation.

Resolves #102697.

Copy link

github-actions bot commented Aug 28, 2024

✅ With the latest revision this PR passed the Python code formatter.

This patch sets lit's internal shell to be the default shell wehn
running llvm tests. Tests that REQUIRES: shell are not currently
supported by the internal shell, so those tests are skipped with this
implementation.
external shell

The original logic for enabling the external shell was faulty, and is
fixed in this patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[llvm][llvm-lit] Enable internal shell for llvm test suite
1 participant