[llvm][llvm-lit] Enabled lit internal shell for llvm test suite #106324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
This patch sets lit's internal shell to be the default shell wehn running llvm tests. Tests that REQUIRES: shell are not currently supported by the internal shell, so those tests are skipped with this implementation.
external shell The original logic for enabling the external shell was faulty, and is fixed in this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sets lit's internal shell to be the default shell when running llvm tests. Tests that
REQUIRES: shellare not currently supported by the internal shell, so those tests are skipped with this implementation.Resolves #102697.