[SelectionDAG] late init DeferredNodes

[klensy]

No need to init SmallVector (even stack allocated) if we can exit literally on next line.

[llvmbot]

@llvm/pr-subscribers-llvm-selectiondag

Author: klensy (klensy)

Changes

No need to init SmallVector (even stack allocated) if we can exit literally on next line.

---

Full diff: https://github.com/llvm/llvm-project/pull/123461.diff

1 Files Affected:

• (modified) llvm/include/llvm/CodeGen/SelectionDAGNodes.h (+1-1)

diff --git a/llvm/include/llvm/CodeGen/SelectionDAGNodes.h b/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
index 03899493847b39..49467ce0a54cd0 100644
--- a/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
+++ b/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
@@ -916,10 +916,10 @@ END_TWO_BYTE_PACK()
                                    SmallVectorImpl<const SDNode *> &Worklist,
                                    unsigned int MaxSteps = 0,
                                    bool TopologicalPrune = false) {
-    SmallVector<const SDNode *, 8> DeferredNodes;
     if (Visited.count(N))
       return true;
 
+    SmallVector<const SDNode *, 8> DeferredNodes;
     // Node Id's are assigned in three places: As a topological
     // ordering (> 0), during legalization (results in values set to
     // 0), new nodes (set to -1). If N has a topolgical id then we

[topperc]

LGTM

[topperc]

@klensy do you need someone to commit this?

[klensy]

@klensy do you need someone to commit this?

Yes, please.