Skip to content

[HLSL][SPRIV] Handle signed RWBuffer correctly #144774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[HLSL][SPRIV] Handle signed RWBuffer correctly #144774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d3d8bb
[HLSL][SPRIV] Handle sign RWBuffer correctly
s-perron Jun 18, 2025
b28c8f8
Merge branch 'main' into signed_buffer
s-perron Jun 19, 2025
8a82c0d
Fixes from code review.
s-perron Jun 19, 2025
742bb69
Add tests using both signed and unsigned together with same image type.
s-perron Jun 19, 2025
919ac3e
Merge branch 'main' into signed_buffer
s-perron Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,9 @@ bool sampledTypeIsSignedInteger(const llvm::Type *HandleType) {
if (TET->getTargetExtName() == "spirv.Image") {
return false;
}
return TET->getTypeParameter(0)->isIntegerTy();
}
assert(TET->getTargetExtName() == "spirv.SignedImage") {
return TET->getTypeParameter(0)->isIntegerTy();
}
} // end anonymous namespace

#define GET_GLOBALISEL_IMPL
Expand Down
1 change: 0 additions & 1 deletion offload-test-suite
Open in desktop
Submodule offload-test-suite deleted from ef40d7
Loading