Skip to content

add(kinesis): Include new Scala engine and performance section #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2025

Conversation

gregfurman
Copy link
Contributor

Motivation

Document the newly introduced Kinesis Mock Scala engine in addition to a small section on performance tuning of the Kinesis service.

Changes

@gregfurman gregfurman requested review from joe4dev and HarshCasper June 5, 2025 12:07
@gregfurman gregfurman self-assigned this Jun 5, 2025
@gregfurman gregfurman added the documentation Improvements or additions to documentation label Jun 5, 2025
Copy link

github-actions bot commented Jun 5, 2025

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1786.surge.sh 🎊

@gregfurman gregfurman marked this pull request as ready for review June 5, 2025 12:10
@localstack localstack deleted a comment Jun 5, 2025
@localstack localstack deleted a comment Jun 5, 2025
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after adding the config to our global reference

@@ -173,11 +173,27 @@ You can fetch the CloudWatch logs for your Lambda function reading records from

| Variable | Description |
| -------- | ----------- |
| `KINESIS_MOCK_PROVIDER_ENGINE` | String value of `node` (default) or `scala` that determines the underlying build of Kinesis Mock. [^scala-future] |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Can we add the configuration to the global LocalStack configuration page: https://docs.localstack.cloud/references/configuration/#kinesis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -173,11 +173,27 @@ You can fetch the CloudWatch logs for your Lambda function reading records from

| Variable | Description |
| -------- | ----------- |
| `KINESIS_MOCK_PROVIDER_ENGINE` | String value of `node` (default) or `scala` that determines the underlying build of Kinesis Mock. [^scala-future] |
| `KINESIS_MOCK_MAXIMUM_HEAP_SIZE` | JVM memory format string (default: `512m`) that sets the maximum memory size for the Kinesis Mock Scala server, corresponds to the JVM `-Xmx` flag. [^scala] |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: great clarity explaining what happens under the hood 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI – I have removed this section and added a redirect to the config docs. Right now, all config vars for individual services are documented there but this can change in future.

- Reduce `KINESIS_LATENCY` artificial response delays from the default `500` milliseconds (or disable entirely with `0`).

[^scala]: This feature is only available in the more performant Scala Kinesis Mock build that can be toggled by setting `KINESIS_MOCK_PROVIDER_ENGINE=scala`.
[^scala-future]: Future versions of LocalStack will likely default to using the `scala` engine over the less-performant `node` version currently in use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Are we aware of any limitations worth mentioning? If not, it might be worth mentioning that we are unaware of any limitations and encourage users to raise a GH issue if they encounter any challenges.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the potential for higher memory overhead (since we pre-allocate 256m by default to the JVM) I'm not sure I can think of any

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then let's be transparent and add that explicitly 👍

@HarshCasper HarshCasper merged commit 7bd1702 into main Jun 7, 2025
5 checks passed
@HarshCasper HarshCasper deleted the kinesis/performance-section branch June 7, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants