Skip to content

Implemented sort by answer and rewrote core part of code to allow for multi filters #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

silasm01
Copy link

Added new filter to only show assignments that has been seen by teacher. Whether or not grade has been set
Also rewrote code to where each filter can take multiple parameters:
[["5", "Afventer"],["7","Lærer"]]
Also rewrote to fix weird behavior where multiple filters override each other.
Now you can use multiple filter at once without any problems.

@Reikimann Reikimann linked an issue Jan 26, 2024 that may be closed by this pull request
Copy link
Collaborator

@Reikimann Reikimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the commit! :D Also please explain the numbers in this: [["5", "Afventer"],["7","Lærer"]].

@Reikimann Reikimann added the enhancement New feature or request label Jan 26, 2024
@silasm01 silasm01 requested a review from Reikimann January 27, 2024 19:20
@Reikimann Reikimann removed the request for review from logicguy1 January 29, 2024 08:53
Deleted comment
Deleted unused line.
Reikimann
Reikimann previously approved these changes Feb 2, 2024
Copy link
Collaborator

@Reikimann Reikimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silasm01 have you tested the code? Its not working. I've tried going back to the other commits you've done, but they aren't working either. Could you please look at it?

@Reikimann Reikimann self-requested a review February 2, 2024 09:56
@Reikimann Reikimann dismissed their stale review February 2, 2024 09:58

The code looked fine, but it isn't working.

@silasm01
Copy link
Author

silasm01 commented Feb 2, 2024

This works fine for Firefox. Although i just checked on chrome and after converting to map() it seems to be broken on chrome. It throws an error:
Uncaught TypeError: Cannot read properties of null (reading 'map')
With a stack trace going to line 194.

@silasm01
Copy link
Author

silasm01 commented Feb 2, 2024

This seemed to be caused by chrome trying to access localStorageItems before they have been loaded as it tries to preload the extension. This has been fixed by checking if localStorageItems is Null before using them. It seems that it works for both Chrome and Firefox now. Found fix at: https://stackoverflow.com/questions/70264846/%C3%97-typeerror-cannot-read-properties-of-null-reading-map.

@Aech27
Copy link
Collaborator

Aech27 commented Feb 3, 2024

Okay, otherwise i will be able to look for a fix in chromium based browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show waiting assignments
3 participants