-
Notifications
You must be signed in to change notification settings - Fork 1
Implemented sort by answer and rewrote core part of code to allow for multi filters #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the commit! :D Also please explain the numbers in this: [["5", "Afventer"],["7","Lærer"]]
.
Deleted comment
Deleted unused line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silasm01 have you tested the code? Its not working. I've tried going back to the other commits you've done, but they aren't working either. Could you please look at it?
The code looked fine, but it isn't working.
This works fine for Firefox. Although i just checked on chrome and after converting to map() it seems to be broken on chrome. It throws an error: |
This seemed to be caused by chrome trying to access localStorageItems before they have been loaded as it tries to preload the extension. This has been fixed by checking if localStorageItems is Null before using them. It seems that it works for both Chrome and Firefox now. Found fix at: https://stackoverflow.com/questions/70264846/%C3%97-typeerror-cannot-read-properties-of-null-reading-map. |
Okay, otherwise i will be able to look for a fix in chromium based browsers |
Added new filter to only show assignments that has been seen by teacher. Whether or not grade has been set
Also rewrote code to where each filter can take multiple parameters:
[["5", "Afventer"],["7","Lærer"]]
Also rewrote to fix weird behavior where multiple filters override each other.
Now you can use multiple filter at once without any problems.