Skip to content

[ci] Switch to golangci-lint #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2021
Merged

[ci] Switch to golangci-lint #279

merged 3 commits into from
Mar 1, 2021

Conversation

wybczu
Copy link
Collaborator

@wybczu wybczu commented Mar 1, 2021

As we're no longer use metalinter in m3 monorepo it makes sense to switch to golangci-lint here too.

Fixes #278.

As we're no longer use metalinter in m3 monorepo it makes sense to switch to
golangci-lint here too.
@wybczu wybczu requested review from schallert and jeromefroe March 1, 2021 19:58
max-same-issues: 0

# Show only new issues created after git revision `REV`
new-from-rev: a0ecbf9d10486673d7581f4e6a8b0f30497f8a66
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many errors are there if we remove this? I.e. is it worth it to bite the bullet now and fix them?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, it looks pretty gnarly. This SGTM.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Around 600 errors. Top 5 linters by error count:

 138 paralleltest
 115 gci
 105 lll
  44 errcheck
  30 errorlint

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #279 (3e3d872) into master (bf640c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   76.10%   76.10%           
=======================================
  Files          32       32           
  Lines        2381     2381           
=======================================
  Hits         1812     1812           
  Misses        426      426           
  Partials      143      143           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf640c6...3e3d872. Read the comment docs.

@wybczu wybczu merged commit caafdf3 into master Mar 1, 2021
@wybczu wybczu deleted the luk/switch-to-golangci branch March 1, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from gometalinter to golangci-lint
2 participants