Skip to content

fix: update execa dependency to 2.1.0#147

Merged
shellscape merged 1 commit intomafintosh:masterfrom
Trott:update-execa
Oct 10, 2019
Merged

fix: update execa dependency to 2.1.0#147
shellscape merged 1 commit intomafintosh:masterfrom
Trott:update-execa

Conversation

@Trott
Copy link
Copy Markdown
Contributor

@Trott Trott commented Oct 10, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

If yes, please describe the breakage.

Please Describe Your Changes

Update execa dependency to 2.1.0 in package-lock.json. Without this
change, tests will fail when run with Node.js 13.x-pre and may fail when
13.0.0 is released in 13 days.

Refs: sindresorhus/execa#370

Update execa dependency to 2.1.0 in package-lock.json. Without this
change, tests will fail when run with Node.js 13.x-pre and may fail when
13.0.0 is released in 13 days.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 10, 2019

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files           1        1           
  Lines         145      145           
=======================================
  Hits          141      141           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d221504...15f0d7b. Read the comment docs.

@shellscape
Copy link
Copy Markdown
Collaborator

Thanks for this PR 🍺

@shellscape shellscape merged commit 264e15a into mafintosh:master Oct 10, 2019
@Trott
Copy link
Copy Markdown
Contributor Author

Trott commented Oct 10, 2019

I know it's just a test fix, but any chance I can persuade you to publish a new release? There seem to be some legitimate bug fixes since the last release, so it wouldn't be a complete no-change release for end users. This particular fix will help Node.js's ecosystem-testing tool CITGM, which downloads a tarball of the latest release and runs tests. So CITGM won't use this fix until it's part of a release.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (d221504) to head (15f0d7b).
⚠️ Report is 15 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files           1        1           
  Lines         145      145           
=======================================
  Hits          141      141           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants