[WIP] #558 #7 Developer can style content types output differently per viewport - fix broken tests #627
Conversation
lbvaimo
changed the title
lbvaimo
changed the title
lbvaimo
changed the title
lbvaimo
changed the title
|
@lbvaimo unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
|
@lbvaimo unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
1 similar comment
|
@lbvaimo unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
lbvaimo
added
2.4-develop: exclude
| --> | ||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="validateAdvancedConfigurationAllOptions"> |
There was a problem hiding this comment.
need to update ALL new actiongroups to adhere to the MFTF static checks
- pascal case
- name must end in
ActionGroup - add description to each new action group
| @@ -7,7 +7,7 @@ | |||
| --> | |||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | |||
| <actionGroup name="validateAdvancedStyleWithAlignment"> | |||
| <actionGroup name="validateAdvancedStyleWithAlignment" deprecated="Styles are not inline"> | |||
There was a problem hiding this comment.
include the name of the actiongroup that external test writers should change to. for this one, that would be validateAdvancedConfigurationWithAlignment. so change to
deprecated="Styles are not inline. Use validateAdvancedConfigurationWithAlignment instead."
update ALL deprecated action groups
There was a problem hiding this comment.
All deprecated action groups updated
| --> | ||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="validateAdvancedConfigurationWithAlignment"> |
There was a problem hiding this comment.
rather than rewriting the actiongroup, wouldn't it be better to extend validateAdvancedConfigurationAllOptions instead?
extend for all similar actiongroups below (advanced config, background config, heading config, etc)
| */ | ||
| --> | ||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
| <actionGroup name="validateBackgroundConfigurationWithNoImage"> |
There was a problem hiding this comment.
rather than rewriting the actiongroup, wouldn't it be better to extend validateAllBackgroundAttributesActionGroup instead?
| <arguments> | ||
| <argument name="page" defaultValue=""/> | ||
| <argument name="index" defaultValue="1" type="string"/> | ||
| <argument name="lineColor" defaultValue="PageBuilderDividerLineColor_Default"/> |
There was a problem hiding this comment.
these 3 data entity arguments would be much better if you change the arguments to be {{PageBuilderDividerLineColor_Default.rgb}} and line 21 to be {{lineColor}}. that way, test writers are not restricted to only using a data entity with an rgb value
also change lineThickness & lineWidth
| <actionGroup name="validateAdvancedConfigurationAllOptions"> | ||
| <arguments> | ||
| <argument name="page" defaultValue=""/> | ||
| <argument name="alignment" defaultValue="PageBuilderAdvancedAlignmentPropertyDefault"/> |
There was a problem hiding this comment.
change all new actiongroups like this one to use string arguments instead of data entity argument.
ex: change default value to {{PageBuilderAdvancedAlignmentPropertyDefault.value}} and line 26 to be {{alignment}}. that way, test writers are not restricted to only using a data entity with a specific key. (it's easy to see the value in this change for borderColor where you can have an rgb input, hex, rgba, plaintext, etc)
There was a problem hiding this comment.
The drawback is that all modified tests will have to be changed again.
Rgb and other data keys (mainly rgb and value were used) can be always added to existing colors,
keeping everything as variables forces to use them, instead of unorganized string values
ex. rgb(250, 250, 250) as an argument instead of {{PageBuilderStageBackgroundColor_Default.rgb}}
| <argument name="showControls" defaultValue="PageBuilderMapShowControls_Default"/> | ||
| <argument name="index" defaultValue="1" type="string"/> | ||
| </arguments> | ||
| <comment userInput="validateMapSettings" stepKey="comment"/> |
There was a problem hiding this comment.
delete all <comment> actions on ALL new actiongroups
| <argument name="index" defaultValue="1" type="string"/> | ||
| </arguments> | ||
| <comment userInput="validateMapSettings" stepKey="comment"/> | ||
| <waitForElementVisible selector="{{page.base(index)}}" stepKey="seeMap"/> |
There was a problem hiding this comment.
stepKey should be waitForMap
| </assertEquals> | ||
| <waitForElement selector="{{page.showControls(index, showControls.value)}}" stepKey="waitForShowControls"/> | ||
| <dontSeeElement selector="{{page.showControls(index, showControls.value)}}" stepKey="dontSeeShowControls"/> | ||
| <seeElementInDOM selector="{{page.showControls(index, showControls.value)}}" stepKey="seeInDOMShowControls"/> |
There was a problem hiding this comment.
not sure why the original actiongroup contained this line but it's useless. please delete
| @@ -77,6 +77,31 @@ | |||
| <entity name="PageBuilderButtonItemType_Link" type="pagebuilder_button_item_type_property" extends="PageBuilderButtonItemType_Template"> | |||
| <data key="value">pagebuilder-button-link</data> | |||
| </entity> | |||
| <!-- Button Primary --> | |||
| <entity name="PageBuilderButtonPrimary_BackgroundColor" type="pagebuilder_button_item_primary_property"> | |||
There was a problem hiding this comment.
why not throw all of the below into 1 data entity? something like PageBuilderButtonPrimary_StyleAttributes
…onents are always nested in a Contained component - Fixing MFTF CR feedback
…onents are always nested in a Contained component - Fixing filename
…lder into imported-magento-magento2-page-builder-631
…gento2-page-builder-631 [Imported] MC-35402: [Page Builder] New top-level Full-Width and Full-Bleed comp�
…ew groups, changed name in Pascal caps format
|
@magento run Functional Tests EE |
- were updated ALL deprecated action groups
|
@magento run Functional Tests EE |
1 similar comment
|
@magento run Functional Tests EE |
- fixed bugs in test generation and changed all references on groups
|
@magento run Functional Tests EE |
1 similar comment
|
@magento run Functional Tests EE |
- I changed references in PB-EE in PR 173 - I made refactoring follow groups: ValidateAdvancedConfigurationWithAlignmentActionGroup ValidateAdvancedConfigurationWithBorderColorActionGroup ValidateAdvancedConfigurationWithCssClassesActionGroup ValidateAdvancedConfigurationWithNoAlignmentActionGroup ValidateAdvancedConfigurationWithNoAlignmentEmptyBorderRadiusActionGroup ValidateAdvancedConfigurationWithNoBorderActionGroup ValidateAdvancedConfigurationWithNoBorderRadiusActionGroup
|
@magento run Functional Tests EE |
…rt - Banner Content Type Mftf fixes
…magento2-page-builder into 558_7_content-type-style-attribute-removal
|
@magento run Functional Tests EE |
…rt - Banner Content Type Mftf fixes
- I made refactoring follow groups: ValidateAdvancedConfigurationWithNoBorderWidthActionGroup ValidateAdvancedConfigurationWithNoMarginsActionGroup ValidateAdvancedConfigurationWithNoPaddingActionGroup
…te-removal' into 558_7_content-type-style-attribute-removal
|
@magento run Functional Tests EE |
- I made refactoring follow groups: ValidateAdvancedConfigurationWithNoMarginsActionGroup ValidateBackgroundConfigurationWithNoImageActionGroup
|
@magento run Functional Tests EE |
omiroshnichenko
deleted the
558_7_content-type-style-attribute-removal
branch
Story
As a developer I want to easily create themes and customizations to existing Page Builder content types to enable me align their visual output with my desired theme
Business Value
ability to style content with CSS classes not using !important
Acceptance Criteria
Technical Vision
Story
#558
Related Pull Requests
https://github.com/magento/magento2-page-builder-ee/pull/173
Checklist