Magento_Persistent performance overhead on non-cart, non-checkout pages

[adamwaclawczyk]

Summary

Preconditions (*)

1. Products added to cart

Steps to reproduce (*)

1. Enter PDP with profiler enabled
2. Quote is not expired and the quote is fully loaded to check this, performance suffers

Expected result (*)

1. persistent_quote observer does not load the quote before it's absolutely necessary

Actual result (*)

1. persistent_quote is loading the full quote with expensive assignProducts function call

Magento_Persistent adds controller_action_predispatch event persistent_quote observer. On non-cart, non-checkout pages(e.g. PDP) it's loading quote and it impacts the TTFB significantly. Due to the observer's private function declarations, overriding the logic inside the observer class requires developers to add class preference or patch the observer class directly. There is no "ok" way to implement workaround for this.

magento2/app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php

Line 164 in dc87600

&& $this->isActiveQuote()

magento2/app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php

Line 166 in dc87600

return (bool)$this->getQuote()->getIsPersistent();

Both of these calls could be simplified by checking the quote table data directly. The business logic will still be satisfied. If the quote has to be expired, then the quote probably needs to be still loaded fully.

Examples

class QuoteResourceWrapper
{
    public function __construct(
        private readonly ResourceConnection $resourceConnection
    ) {
    }

    public function isActive(?int $quoteId): bool
    {
        if (empty($quoteId)) {
            return false;
        }
        $table = $this->resourceConnection->getTableName('quote');
        $connection = $this->resourceConnection->getConnection();
        $select = $connection->select()
            ->from($table, 'is_active')
            ->where('entity_id = ?', $quoteId);

        return $connection->fetchOne($select) == true;
    }

    public function isPersistent(?int $quoteId): bool
    {
        if (empty($quoteId)) {
            return false;
        }
        $table = $this->resourceConnection->getTableName('quote');
        $connection = $this->resourceConnection->getConnection();
        $select = $connection->select()
            ->from($table, 'is_persistent')
            ->where('entity_id = ?', $quoteId);

        return $connection->fetchOne($select) == true;
    }
}

Proposed solution

Do not load quote fully if not needed.
I have prepared a sample class that could be used as a wrapper for getting the required data instead, see Examples

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @adamwaclawczyk. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @adamwaclawczyk,

Thanks for the report & collaboration!

We have tried to reproduce the issue in the latest development branch (Vanilla) i.e. 2.4-develop but it seems the issue is not reproducible for us. Please refer to the below screenshot for reference:

Let us know if we missed anything.

Thanks