feat: Add !pip metadata from ipynb convert and handle ! commands #7141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
requested review from
manzt and
mscolnick
and removed request for
manzt
mscolnick
reviewed
Nov 11, 2025
mscolnick
reviewed
Nov 11, 2025
mscolnick
approved these changes
Nov 11, 2025
Collaborator
Author
|
Great, going to follow up with a change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
! comand in jupyteris a valid method of running a subprocess. We now explicitly handle this in conversion to use
subprocess.call. In explicit cases of!pipinstall, we leave a comment instead, and add the pip install to package metadata