Skip to content

Fix <RichTextField> should render emptyText when value is an empty string #10670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Apr 16, 2025

Problem

<RichTextField> does not render emptyText when the value is equal to ''.

Solution

Fix <RichTextField> to render emptyText when the value is an empty string.

How To Test

Unit test + new Story

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djhi djhi merged commit 7157b5c into master Apr 16, 2025
0 of 2 checks passed
@djhi djhi deleted the RichTextField-emptyText branch April 16, 2025 09:58
@djhi djhi added this to the 5.7.3 milestone Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Development

Successfully merging this pull request may close these issues.

2 participants