Skip to content

Fix <Confirm> ignore simple string title and content props #10723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented May 5, 2025

Problem

#10654 introduced an issue: when passing string to the title or content props that are not translation keys, the default translation is displayed.

Solution

Don't pass a default translation when those props are provided.

How To Test

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added the RFR Ready For Review label May 5, 2025
@fzaninotto fzaninotto merged commit 581a9fa into master May 5, 2025
16 checks passed
@fzaninotto fzaninotto deleted the fix-confirm-simple-string-ignored branch May 5, 2025 08:33
@fzaninotto fzaninotto added this to the 5.8.1 milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Development

Successfully merging this pull request may close these issues.

2 participants