Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a rerender loop when viewing the boolean input story when is it disabled.
Solution
Do not try to reset the field when the input is disabled. If you need an updated
defaultValue
while still having the input disabled, you should usereadOnly
.How To Test
View and play with the Disabled story of BooleanInput: https://react-admin-storybook-i09ggoby2-marmelab.vercel.app/?path=/story/ra-ui-materialui-input-booleaninput--disabled
Additional Checks
master
for a bugfix or a documentation fix, ornext
for a feature