Skip to content

Fix bulk action buttons hover style #10788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025
Merged

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jun 18, 2025

Problem

Buttons (especially BulkDeleteButton) look weird on hover in the BulkActionToolbar.
image

Solution

  • Remove the default styles applied in the components code.
  • Adjust the themes so that they look nice

image

How To Test

  • make run-demo
  • http://localhost:8000/#/orders
  • Check the select all checkbox
  • Move hover each button of the BulkActionToolbar
  • Check all themes in both light and dark mode

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature

@djhi djhi added the RFR Ready For Review label Jun 18, 2025
@fzaninotto fzaninotto changed the title Fix bulk actions styles Fix bulk action buttons hover style Jun 18, 2025
@fzaninotto fzaninotto merged commit 6bdd398 into master Jun 18, 2025
15 checks passed
@fzaninotto fzaninotto deleted the fix-bulk-actions-styles branch June 18, 2025 13:04
@fzaninotto fzaninotto added this to the 5.8.5 milestone Jun 18, 2025
@djhi djhi modified the milestones: 5.8.5, 5.9.0 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Development

Successfully merging this pull request may close these issues.

2 participants