Skip to content

Add tests for field language #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: mainline
Choose a base branch
from

Conversation

farshidz
Copy link
Collaborator

@farshidz farshidz commented Jul 1, 2025

Change Summary

There are no tests verifying language is correctly set in the schema. This PR adds this as integ and API tests.

Related Jira Ticket

N/A

Checklist

  • Tests have been added for changes
  • Documentation has been updated
  • Breaking changes are clearly identified
  • Python client changes linked or N/A

For new field types:

  • Tests cover score modifier usage of this new type
  • Test indexes updated to cover the new type for all APIs (add docs, search, partial update, etc.)

@farshidz farshidz force-pushed the farshid/test-language-mapping branch 2 times, most recently from 0e3dc72 to 7b75fc6 Compare July 1, 2025 07:47
@farshidz farshidz force-pushed the farshid/test-language-mapping branch from 7b75fc6 to 8bc2df3 Compare July 1, 2025 07:48
tensor_fields=[],
mappings={
"title_pt": {"type": "text_field", "language": "pt"},
"title_en": {"type": "text_field", "language": "end"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is end a typo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants