Add Lighthouse workflow #1040
Merged
Add Lighthouse workflow #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an action that runs Lighthouse against the root page of the website to check for any issues.
Remove the -WindowStyle flag.
Codecov Report
@@ Coverage Diff @@
## main #1040 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 50 50
Lines 823 823
=======================================
Hits 742 742
Misses 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Set a number of configuration options to use.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | https://localhost:5001 |
| Device | URL |
|---|---|
| mobile | https://localhost:5001 |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
Audit the production website to test a theory.
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | https://martincostello.com |
| Device | URL |
|---|---|
| mobile | https://martincostello.com |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
Audit the local site again, as auditing production didn't work either.
Upload the Lighthouse report to the artifacts.
Just in case, normalize the path separators for Linux.
Request the URL before running Lighthouse.
Try and see what might be failing when the process starts.
Run dotnet dev-certs to configure the HTTPS certificate.
Run the server as a new process again.
Run on Windows instead of Linux to make it easier to persist the dotnet process.
Try and keep the child process alive to run the server.
Add a sleep to see if it's just not started yet.
Ignore warning for self-signed TLS certificate.
Parameterise the URL to test.
Refactor the code to check for the website being running.
Fix casing to see if that's why it failed.
Remove Out-Null in case it's losing the response.
Use environment variable again for the website URL.
Use a literal as the variable doesn't seem to work.
Generate the certificate automatically.
Fix report not being output.
Ensure the directory to put the reports in exists.
Hide the output from creating the report directory.
Build the CSS and JavaScript.
Use npm ci instead of npm install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an action that runs Lighthouse against the root page of the website to check for any issues.