Add caption with doc and specs#68
Merged
pascalwengerter merged 3 commits intodevelopfrom Jun 29, 2019
Merged
Conversation
Contributor
|
Hey @michaelrevans this looks great to me. One little request: Could you move the if/else block into the |
Contributor
|
@michaelrevans could you change the target branch to |
Collaborator
Author
|
@PasWen thanks for the comments, I've made the changes you requested. Ready now for re-review 👍 |
pascalwengerter
approved these changes
Jun 29, 2019
Contributor
pascalwengerter
left a comment
pascalwengerter
left a comment
There was a problem hiding this comment.
Great work @michaelrevans, we're good to merge!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #52: Add
captioncore componentChanges
Notes
N/A