Action to push to the MathJax repository
#1275
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1275 +/- ##
========================================
Coverage 86.68% 86.68%
========================================
Files 337 337
Lines 84105 84105
Branches 4750 4750
========================================
Hits 72909 72909
Misses 11173 11173
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
A couple of suggestions for this.
One additional one is that the package.json version should be adjusted to match the source version, as well.
Do we still need the three non-mathjax dependencies in the MathJax repo's package.json? We needed them in the past for people using the mathjax npm package in node applications that include speech generation. Is that still the case?
| ./components/bin/version | ||
| pnpm -s link:src | ||
| pnpm -s build | ||
|
|
There was a problem hiding this comment.
Since this will have been done as part of publishing the npm package, I'm wondering if we can't just install the npm package rather than rebuild everything again. That way, we are sure the two packages are actually the same.
| git checkout -b "$RELEASE_NAME" | ||
|
|
||
| # Copy the build output from MathJax-src repo to MathJax | ||
| cp -r ../bundle/* ./ |
There was a problem hiding this comment.
You may want to remove the old files first, in case any were deleted or renamed. For example, we are not having the -full files any more and if we don't delete them, they will remain in the package.
You might look a the 4.0.0-beta.7 package.json file's scripts to see what is currently done.
PR adds an action that pushes the new release to the
MathJaxrepository, creating a branch with the new release name and making pull request into develop.publishaction. For ease of testing I kept it separately.actup to the point of actually pushing the branch as this needs a token that is automatically created on Github but cannot be simulated inact.