Add support for more repository address formats #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbuzinski
approved these changes
Jun 20, 2025
public/scripts/workflow.js
Outdated
Comment on lines
38
to
44
| if (parts.length === 2 && parts[0].includes(".")) { | ||
| // host/owner (missing repo) | ||
| return { | ||
| origin: `https://${parts[0]}`, | ||
| owner: parts[1], | ||
| repo: parts[2], // will be undefined, so will be caught below | ||
| }; |
There was a problem hiding this comment.
The logic looks correct, but I think the comment is off. This looks like the github.com/owner/repo case
There was a problem hiding this comment.
Oh, nevermind. I see it's parts.length === 2. I am a little confused about parsing and returning for this case. This is to handle false positive matches where they left off the repo? If we don't include this, we'll accidentally match?
There was a problem hiding this comment.
Removed. AI snuck it past me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for SSH and git protocol repository address formats.
With this change, we can now parse:
SSH and git protocol (ssh branch):
[email protected]:owner/repossh://[email protected]/owner/repogit://github.com/owner/repo[email protected]:enterprises/enterprise/owner/repo(GitHub Enterprise)Shorthand and domain/owner/repo:
owner/repo(shorthand, assumes github.com)github.com/owner/repoHTTP(S) URLs:
https://github.com/owner/repohttps://github.com/enterprises/enterprise/owner/repo(GitHub Enterprise)Closes #5