v5.2.0 is breaking ... can't say exactly what

[binarykitchen]

This with your latest v5.2.0 breaking my www.videomail.io app - had to revert back to 5.1.2

Afraid I can't exactly say what it is.

[binarykitchen]

If it helps, objectMode is set to true and perMessageDeflate to false here

[mcollina]

Reverted in v5.3.0.

@scarry1992 can you please send the PR again?

[scarry1992]

@mcollina, I remove my fork already. What going on?

[mcollina]

It seems your changes are breaking @binarykitchen. Your code is still available on 76ec47a.

[scarry1992]

ok then, I remake PR. But what case breaks my changes?

[scarry1992]

@mcollina, #149. Ok?

[binarykitchen]

sorry guys, been busy. trying to give you more information here to reproduce:

1. git clone https://github.com/binarykitchen/videomail-client
2. run example with yarn start, all works fine
3. bump websocket-stream dependency to 5.2.0
4. try one example again, it fails, behaves differently (always connecting)

i've also opened console and can see a different sequence of events emitted

before (when it worked) it was

1. resume, 2. uncork, 3. connect and then 4. data

but after, with v5.2.0 it is

1. resume, 2. connect and 3. preend (ends too early?)

afraid cant tell more. but feel free to use this repo to reproduce the problem.

[nuharaf]

I am getting bunch of self is undefined and state is undefined using 5.30, work OK with 5.12. What I do is simply try to do mqtt.connect from mqttjs.

[AlexStacker]

After upgrading to 5.3.0, the version number of the readable-stream library used is 3.0, which makes mqtt not work properly. It seems that the process-nextick-args is removed. Can it be solved as soon as possible?

[AlexStacker]

By setting the webpack node environment variable is already ok

[mcollina]

Should be fixed in 5.4.0