This repository was archived by the owner on Feb 17, 2023. It is now read-only.
Allow in-line commentted imports (optional) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(a) Source file lints better and (b) can be used standalone (provided any required dependancies are loaded manually)
|
In this perspective it's worth noting that "import" inside a multi-line comment /* ... */ are executed (in current SMASH master), but resulting code fails if it contains multi-line comments as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(a) Source file lints better
(b) Source file can be used standalone (provided any required dependencies are loaded manually)
This is not strictly backwards compatible, as any previous source code with commented imports (meant not to execute) will execute under this commit.