Add nodejs data for CustomEvent
#24955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
caugner
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The version table of
CustomEventin globals and events are inconsistent (note thatCustomEventcan only be accessed globally), after checking the node release note, confirmed data in two modules should be used, so fired an issue at nodejs/node#55733https://nodejs.org/docs/latest/api/globals.html#customevent
https://nodejs.org/docs/latest/api/events.html#class-customevent
--experimental-global-customeventCLI flag in v18.7.0, v16.17.0, default disabledhttps://nodejs.org/en/blog/release/v16.17.0/
https://nodejs.org/en/blog/release/v18.7.0/
nodejs/node#43885
nodejs/node#43514
--experimental-global-customeventCLI flag and add--no-experimental-global-customeventCLI flag in v19.0.0, default enabledhttps://nodejs.org/en/blog/release/v19.0.0/
nodejs/node#44860
https://nodejs.org/en/blog/release/v20.13.0/
https://nodejs.org/en/blog/release/v22.1.0/
nodejs/node#52618
--no-experimental-global-customeventCLI flag in v23.0.0, default enabledhttps://nodejs.org/en/blog/release/v23.0.0/
nodejs/node#52723
also, previous data is added in #23120
Test results and supporting details
Related issues