Add Request() constructor init.duplex parameter#25488
Merged
Conversation
caugner
reviewed
Jan 2, 2025
Comment on lines
+245
to
+265
| "nodejs": [ | ||
| { | ||
| "version_added": "19.3.0" | ||
| }, | ||
| { | ||
| "version_added": "18.13.0", | ||
| "version_removed": "19.0.0" | ||
| } | ||
| ], |
Contributor
There was a problem hiding this comment.
Can you share links to the PRs/commits?
Contributor
Author
There was a problem hiding this comment.
it is added in nodejs/node@216b5a1#diff-1548e1d5e2941cd3f8042e4b5bf7f5f985e48bd7aee50f938739f9e067366e8cR476-R480, and nodejs/node#45236, so the version should be 19.1.0, 18.13.0, 16.19.0
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
caugner
requested changes
Jan 13, 2025
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
c735b98 to
0a53248
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data taken from
Request.duplexTest results and supporting details
Spec proposal change at whatwg/fetch#1493
Related issues
Relates to mdn/content#31735
Depends on #25486 and #25487