This repository was archived by the owner on May 30, 2023. It is now read-only.
Manually exclude long double from bindings #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmwangx
added a commit
to zmwangx/rust-ffmpeg-sys
that referenced
this pull request
Aug 1, 2020
Fixes #1. Inspired by meh/rust-ffmpeg-sys#87 I happened upon, so kudos to kornelski. Though far from ideal, not sure why I didn't think of this. As to white blacklist instead of whitelist: FFmpeg is a huge library with too damn many functions. I guess we could whitelist av.*, pp.* and sw.*, but I don't want to risk missing anything, present or future. So here goes the crappy blacklist.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bindgen has a problem generating bindings for
long double, which causes lots of warnings from rustc: rust-lang/rust-bindgen#1549This excludes unused functions with long double args.