Skip to content

Embed unimplemented server by value instead of pointer#219

Merged
shuheiktgw merged 1 commit intomainfrom
fix_unimplemented_server
Aug 6, 2024
Merged

Embed unimplemented server by value instead of pointer#219
shuheiktgw merged 1 commit intomainfrom
fix_unimplemented_server

Conversation

@shuheiktgw
Copy link
Copy Markdown
Contributor

Since grpc/grpc-go#7438 was merged, our unit tests started failing since we embeded the unimplemented servers by pointer. To fix the problem, use value instead.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 6, 2024

Code Metrics Report

main (98f250e) #219 (c4e1515) +/-
Coverage 65.2% 65.2% 0.0%
Code to Test Ratio 1:0.3 1:0.3 0.0
Test Execution Time 7m11s 7m11s 0s
Details
  |                     | main (98f250e) | #219 (c4e1515) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          65.2% |          65.2% | 0.0% |
  |   Files             |             69 |             69 |    0 |
  |   Lines             |          11756 |          11756 |    0 |
  |   Covered           |           7662 |           7662 |    0 |
  | Code to Test Ratio  |          1:0.3 |          1:0.3 |  0.0 |
  |   Code              |          37082 |          37082 |    0 |
  |   Test              |          12653 |          12653 |    0 |
  | Test Execution Time |          7m11s |          7m11s |   0s |

Reported by octocov

@shuheiktgw shuheiktgw merged commit 95e38b6 into main Aug 6, 2024
@shuheiktgw shuheiktgw deleted the fix_unimplemented_server branch August 6, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants