Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented May 5, 2021

Summary of the Pull Request

What is this about:

Upgrade check-spelling to v0.0.18

What is include in the PR:

  • An advice
  • Note that by default words are only considered if they have at least 3 letters
  • Updated excludes based on advice from the bot (any file which has fewer known words than unknown words)
  • One typo fix

How does someone test / validate:

  1. Create a local fork.
  2. Commit a typo.
  3. Push a branch with that typo -- observe that it's found

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@github-actions
Copy link

github-actions bot commented May 5, 2021

Misspellings found, please review:

  • apos
  • bc
  • bh
  • Chris's
  • cn
  • cx
  • cz
  • df
  • dw
  • EB
  • ev
  • fd
  • fx
  • gh
  • hc
  • hh
  • hk
  • hu
  • ip
  • jp
  • Kf
  • NX
  • pb
  • Pn
  • pv
  • pw
  • px
  • QI
  • ru
  • rv
  • rx
  • sz
  • td
  • tt
  • tw
  • Tz
  • ul
  • uv
  • vh
  • vk
  • vm
  • vw
  • Vx
  • xa
  • XY
  • yy
  • Zc
  • zh
  • zm
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"aaaa ABCDEFGHIJKLMNOPQRSTUVWXYZ activationaction autogenerated changecursor Changemove Chrzan colorhistory colorhistorylimit copiedcolorrepresentation customaction Fody IIO imageresizersettings JSONOf Lambson Laute lzw ncol NETFX NTFS outsettings RUS showcolorname snd SWRESTORE Tadele Toolchain visiblecolorformats VKTAB We'd XBind "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spell-check";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"apos bc bh Chris's chrzan cn cx cz df dw EB ev fd fody fx gh hc hh hk hu ip jp Kf lambson laute LZW NCol NX pb Pn pv pw px QI ru rv rx Snd sz tadele td tt tw Tz ul uv vh vk vm vw Vx xa XY yy Zc zh zm "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@jsoref
Copy link
Contributor Author

jsoref commented May 5, 2021

Tolerate engine upgrades is on my todo list...

@jsoref jsoref marked this pull request as draft May 5, 2021 14:23
@github-actions
Copy link

github-actions bot commented May 6, 2021

Misspellings found, please review:

  • apos
  • bc
  • bh
  • Chris's
  • cn
  • cx
  • cz
  • df
  • dw
  • EB
  • ev
  • fd
  • fx
  • gh
  • hc
  • hh
  • hk
  • hu
  • ip
  • jp
  • Kf
  • NX
  • pb
  • Pn
  • pv
  • pw
  • px
  • QI
  • ru
  • rv
  • rx
  • sz
  • td
  • tt
  • tw
  • Tz
  • ul
  • uv
  • vh
  • vk
  • vm
  • vw
  • Vx
  • xa
  • XY
  • yy
  • Zc
  • zh
  • zm
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"aaaa ABCDEFGHIJKLMNOPQRSTUVWXYZ activationaction autogenerated changecursor Changemove Chrzan colorhistory colorhistorylimit copiedcolorrepresentation customaction Fody IIO imageresizersettings JSONOf Lambson Laute lzw ncol NETFX NTFS outsettings RUS showcolorname snd SWRESTORE Tadele Toolchain visiblecolorformats VKTAB We'd XBind "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spell-check";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"apos bc bh Chris's chrzan cn cx cz df dw EB ev fd fody fx gh hc hh hk hu ip jp Kf lambson laute LZW NCol NX pb Pn pv pw px QI ru rv rx Snd sz tadele td tt tw Tz ul uv vh vk vm vw Vx xa XY yy Zc zh zm "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@jsoref jsoref marked this pull request as ready for review May 6, 2021 02:25
@enricogior
Copy link
Contributor

@jsoref
the PR is currently blocked, do you have an ETA for it? Thanks,

@jsoref
Copy link
Contributor Author

jsoref commented May 7, 2021

@enricogior: If it's just blocked by the old spell-checker, I can put them back and let them get removed after this merges...

jsoref added 2 commits May 7, 2021 06:40
Signed-off-by: Josh Soref <[email protected]>
@enricogior
Copy link
Contributor

@jsoref
yes please because at the moment I can't merge the PR.

@enricogior enricogior merged commit eb10665 into microsoft:master May 11, 2021
@jsoref jsoref deleted the spell-check branch May 11, 2021 12:49
@jsoref jsoref mentioned this pull request May 18, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants